Implemented fullscreen exit animation with AppKit

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 
 #include "base/command_line.h"
@@ skipping 1932 matching lines @@
   if (WebContents* contents = [self webContents]) {
     if (RenderWidgetHostView* rwhv = contents->GetRenderWidgetHostView())
       rwhv->WindowFrameChanged();
   }
 
   // The FindBar needs to know its own position to properly detect overlaps
   // with find results. The position changes whenever the window is resized,
   // and |layoutSubviews| computes the FindBar's position.
   // TODO: calling |layoutSubviews| here is a waste, find a better way to
   // do this.
+

[erikchen, 2015/08/11 22:42:54]

why did you add whitespace here?

[spqchan1, 2015/08/12 19:34:41]

Done.

   if ([findBarCocoaController_ isFindBarVisible])
     [self layoutSubviews];
 }
 
 // Handle the openLearnMoreAboutCrashLink: action from SadTabView when
 // "Learn more" link in "Aw snap" page (i.e. crash page or sad tab) is
 // clicked. Decoupling the action from its target makes unit testing possible.
 - (void)openLearnMoreAboutCrashLink:(id)sender {
   if (WebContents* contents = [self webContents]) {
     OpenURLParams params(GURL(chrome::kCrashReasonURL), Referrer(), CURRENT_TAB,
@@ skipping 181 matching lines @@
 
 - (BOOL)isInAnyFullscreenMode {
   return [self isInImmersiveFullscreen] || [self isInAppKitFullscreen];
 }
 
 - (BOOL)isInImmersiveFullscreen {
   return fullscreenWindow_.get() != nil || enteringImmersiveFullscreen_;
 }
 
 - (BOOL)isInAppKitFullscreen {
-  return ([[self window] styleMask] & NSFullScreenWindowMask) ==
-             NSFullScreenWindowMask ||
-         enteringAppKitFullscreen_;
+  return !exitingAppKitFullscreen_ &&
+         (([[self window] styleMask] & NSFullScreenWindowMask) ==
+              NSFullScreenWindowMask ||
+          enteringAppKitFullscreen_);
 }
 
 - (void)enterExtensionFullscreenForURL:(const GURL&)url
                             bubbleType:(ExclusiveAccessBubbleType)bubbleType {
   if (chrome::mac::SupportsSystemFullscreen()) {
     fullscreenUrl_ = url;
     exclusiveAccessBubbleType_ = bubbleType;
     [self enterBrowserFullscreenWithToolbar:NO];
   } else {
     [self enterImmersiveFullscreen];
@@ skipping 99 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 @end  // @implementation BrowserWindowController(WindowType)