Issue 1276353005: Planned implementation of CreateGattConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276353005: Planned implementation of CreateGattConnection

Created:
5 years, 4 months ago by krstnmnlsn

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews, scheib+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@adapimpl-simple

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

These are the changes I made to implement CreateGattConnection before we decided to move the logic into cross platform code. However there is a lot of plumbing here of callbacks between CoreBluetooth and Chrome that may be useful - at least as a reference - for the actual implementation. Haven't sanity checked this code, or even tried to build it in a while, so no promises, quality not guaranteed :) BUG=

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -9 lines)			Patch
M	device/bluetooth/bluetooth_adapter_mac.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth_adapter_mac.mm	View	3 chunks	+62 lines, -1 line	0 comments	Download
M	device/bluetooth/bluetooth_adapter_mac_unittest.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	device/bluetooth/bluetooth_gatt_connection_mac.mm	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	device/bluetooth/bluetooth_low_energy_central_manager_delegate.mm	View	2 chunks	+31 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth_low_energy_device_mac.h	View	4 chunks	+25 lines, -2 lines	0 comments	Download
M	device/bluetooth/bluetooth_low_energy_device_mac.mm	View	6 chunks	+31 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1261093004 Patch 60001