Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276333006: Really Really fix tests broken at 9778206. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Really Really fix tests broken at 9778206. Stub out failing platform entirely TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/48f1947602817a3b5331b6504518e846addfbd71

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M core/src/fxcrt/fx_system_unittest.cpp View 6 chunks +6 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as 48f1947602817a3b5331b6504518e846addfbd71 (tree was closed).
5 years, 4 months ago (2015-08-07 23:31:06 UTC) #2
Tom Sepez
Lei, its just not my day.
5 years, 4 months ago (2015-08-07 23:32:17 UTC) #3
Tom Sepez
Lei, its just not my day.
5 years, 4 months ago (2015-08-07 23:32:26 UTC) #4
Lei Zhang
lgtm The next PDFium DEPS roll will have a fun changelog. :) https://codereview.chromium.org/1276333006/diff/1/core/src/fxcrt/fx_system_unittest.cpp File core/src/fxcrt/fx_system_unittest.cpp ...
5 years, 4 months ago (2015-08-07 23:36:50 UTC) #5
Lei Zhang
5 years, 4 months ago (2015-08-07 23:37:30 UTC) #6
Message was sent while issue was closed. 
On 2015/08/07 23:36:50, Lei Zhang wrote:
>
https://codereview.chromium.org/1276333006/diff/1/core/src/fxcrt/fx_system_un...
> core/src/fxcrt/fx_system_unittest.cpp:12: // functionality on any given
> platformn.
> BTW, typo heere.

We should just go home.

Powered by Google App Engine
This is Rietveld 408576698