sdk/dart now detects an available build

sdk/dart now detects an available build

The shell scripts in sdk/sdk are using ReleaseIA32 as the default build
configuration in the case one is not provided as an environment
variable. This is arbitrary so a check of the available builds is
performed and if ReleaseIA32 is available it is selected. Otherwise, an
arbitrary configuration is selected (currently the last one
lexicographically). In the case where there are no subfolders in the
"out" folder, ReleaseIA32 is selected, in order to produce the same
error that used to be produced before (this can be changed to a custom
message for user-friendliness).

Currently only the "dart" shell script is changed and if the change is
accepted, the others will be changed too.

R=floitsch@google.com, zerny@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac8a228d0b1dc86cb02f9d15ce0320c4e03b56cd

[stanm, 2015-08-10 08:11:16]

stanm@google.com changed reviewers:
+ zarah@google.com

[floitsch, 2015-08-10 11:48:40]

floitsch@google.com changed reviewers:
- zarah@google.com, zerny@google.com

[floitsch, 2015-08-10 11:48:40]

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode23
sdk/bin/dart:23: CONFIGS=$( ls "$CUR_DIR"/../../out/ )
This only works for Linux.

Create a OUT_DIR variable.

if [[ `uname` == 'Darwin' ]];
then
  OUT_DIR="$CUR_DIR"/../../xcodebuild"
else
  OUT_DIR="$CUR_DIR"/../../out"
fi

if [ -z "$DART_CONFIGURATION" ];
...
fi

BIN_DIR="$OUT_DIR"/$DART_CONFIGURATION

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode31
sdk/bin/dart:31: # lexicographically
I think it would be nicer to have a list of preferred configurations.
This makes it also more robust wrt to spurious folders/files in the
out-directory.

[stanm, 2015-08-10 14:51:40]

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode23
sdk/bin/dart:23: CONFIGS=$( ls "$CUR_DIR"/../../out/ )
On 2015/08/10 11:48:40, floitsch wrote:
> This only works for Linux.
> 
> Create a OUT_DIR variable.
> 
> if [[ `uname` == 'Darwin' ]];
> then
>   OUT_DIR="$CUR_DIR"/../../xcodebuild"
> else
>   OUT_DIR="$CUR_DIR"/../../out"
> fi
> 
> if [ -z "$DART_CONFIGURATION" ];
> ...
> fi
> 
> BIN_DIR="$OUT_DIR"/$DART_CONFIGURATION

Acknowledged.

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode31
sdk/bin/dart:31: # lexicographically
On 2015/08/10 11:48:40, floitsch wrote:
> I think it would be nicer to have a list of preferred configurations.
> This makes it also more robust wrt to spurious folders/files in the
> out-directory.

I thought of doing that initially, but I couldn't find a list of the available
options. I will look into it now.

[floitsch, 2015-08-10 14:56:09]

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode31
sdk/bin/dart:31: # lexicographically
On 2015/08/10 14:51:40, stanm wrote:
> On 2015/08/10 11:48:40, floitsch wrote:
> > I think it would be nicer to have a list of preferred configurations.
> > This makes it also more robust wrt to spurious folders/files in the
> > out-directory.
> 
> I thought of doing that initially, but I couldn't find a list of the available
> options. I will look into it now.

I wouldn't look too far.
I32 und I64 Release and Debug are probably enough.

[floitsch, 2015-08-10 14:56:49]

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/1/sdk/bin/dart#newcode31
sdk/bin/dart:31: # lexicographically
On 2015/08/10 14:56:09, floitsch wrote:
> On 2015/08/10 14:51:40, stanm wrote:
> > On 2015/08/10 11:48:40, floitsch wrote:
> > > I think it would be nicer to have a list of preferred configurations.
> > > This makes it also more robust wrt to spurious folders/files in the
> > > out-directory.
> > 
> > I thought of doing that initially, but I couldn't find a list of the
available
> > options. I will look into it now.
> 
> I wouldn't look too far.
> I32 und I64 Release and Debug are probably enough.

You could furthermore include ARM (don't know what the id is). that should make
it pretty complete.

[stanm, 2015-08-12 09:58:32]

PTAL

[floitsch, 2015-08-12 11:26:08]

LGTM.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode31
sdk/bin/dart:31: COUNT=$( echo $DIRS | wc -w )
You can drop the COUNT part. It will just run through all possible
configurations.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode40
sdk/bin/dart:40: "ReleaseSIMARM" "ReleaseSIMARM64" "ReleaseSIMARMV5TE"
"ReleaseSIMMIPS"
Remove the simarm and simmips (simulated)

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode41
sdk/bin/dart:41: "DebugIA32"   "DebugX64"
Put DebugIA32 and DebugX64 before the ARM ones.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode52
sdk/bin/dart:52: DART_CONFIGURATION=$DIR
"$DIR"

[stanm, 2015-08-12 12:30:18]

Addressed comments.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode31
sdk/bin/dart:31: COUNT=$( echo $DIRS | wc -w )
On 2015/08/12 11:26:08, floitsch wrote:
> You can drop the COUNT part. It will just run through all possible
> configurations.

Done.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode40
sdk/bin/dart:40: "ReleaseSIMARM" "ReleaseSIMARM64" "ReleaseSIMARMV5TE"
"ReleaseSIMMIPS"
On 2015/08/12 11:26:08, floitsch wrote:
> Remove the simarm and simmips (simulated)

Done.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode41
sdk/bin/dart:41: "DebugIA32"   "DebugX64"
On 2015/08/12 11:26:08, floitsch wrote:
> Put DebugIA32 and DebugX64 before the ARM ones.

Done.

https://codereview.chromium.org/1276333002/diff/20001/sdk/bin/dart#newcode52
sdk/bin/dart:52: DART_CONFIGURATION=$DIR
On 2015/08/12 11:26:08, floitsch wrote:
> "$DIR"

Done.

[stanm, 2015-08-12 13:19:34]

Committed patchset #4 (id:60001) manually as
ac8a228d0b1dc86cb02f9d15ce0320c4e03b56cd (presubmit successful).