Move CrTrackingArea from chrome/browser/ui/cocoa to ui/base/cocoa.

Move CrTrackingArea from chrome/browser/ui/cocoa to ui/base/cocoa.

This change moves tracking_area.h, its implementation and tests to
ui/base so that Chrome components outside of the browser can use it.

BUG=138633
TEST=No functional changes


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187441

[tapted, 2013-03-11 07:57:52]

Nico, could you please take a look at this refactoring CL for review and owners?

If it looks good, I'll update
http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts with the new
path as well.

Thanks

[tapted, 2013-03-11 09:42:30]

Sorry - that published oddly because I used the "draft message" feature. Here's
how it should have looked.

Also, a comment about the motivation (beyond the general linked bug): This is
for the OSX app launcher, to add the "hover" highlight used when mousing over
items. Compare, e.g., with the CrOS app launcher. This code all lives outside of
chrome/browser.

Thanks!


Reviewers: thakis

Description:
Move CrTrackingArea from chrome/browser/ui/cocoa to ui/base/cocoa. 

This change moves tracking_area.h, its implementation and tests to 
ui/base so that Chrome components outside of the browser can use it. 

BUG=138633
TEST=No functional changes 


Please review this at https://codereview.chromium.org/12763002/

SVN Base: https://chromium.googlesource.com/chromium/src.git@master

Affected files:
  M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
  M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h
  M chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm
  M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h
  M chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h
  M chrome/browser/ui/cocoa/hover_button.h
  M chrome/browser/ui/cocoa/hover_button.mm
  M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.h
  M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
  M chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.h
  M chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm
  M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h
  M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
  M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
  D chrome/browser/ui/cocoa/tracking_area.h
  D chrome/browser/ui/cocoa/tracking_area.mm
  D chrome/browser/ui/cocoa/tracking_area_unittest.mm
  M chrome/chrome_browser_ui.gypi
  M chrome/chrome_tests_unit.gypi
  A + ui/base/cocoa/tracking_area.h
  A + ui/base/cocoa/tracking_area.mm
  A + ui/base/cocoa/tracking_area_unittest.mm
  M ui/ui.gyp
  M ui/ui_unittests.gypi

[Nico, 2013-03-11 17:42:45]

lgtm!

https://codereview.chromium.org/12763002/diff/3001/ui/base/cocoa/tracking_are...
File ui/base/cocoa/tracking_area_unittest.mm (right):

https://codereview.chromium.org/12763002/diff/3001/ui/base/cocoa/tracking_are...
ui/base/cocoa/tracking_area_unittest.mm:25: class CrTrackingAreaTest : public
ui::CocoaTest {
nit: Aren't tests usually in the same namespace as the class they're testing?

[tapted, 2013-03-11 22:40:22]

Thanks!

Also, heads up: there are presubmit warnings since tracking_area.mm needs to use
NSTrackingArea (will see what CQ says). But no errors, and no other warnings.

https://codereview.chromium.org/12763002/diff/3001/ui/base/cocoa/tracking_are...
File ui/base/cocoa/tracking_area_unittest.mm (right):

https://codereview.chromium.org/12763002/diff/3001/ui/base/cocoa/tracking_are...
ui/base/cocoa/tracking_area_unittest.mm:25: class CrTrackingAreaTest : public
ui::CocoaTest {
On 2013/03/11 17:42:45, Nico wrote:
> nit: Aren't tests usually in the same namespace as the class they're testing?

Good point. Done.

[commit-bot: I haz the power, 2013-03-11 22:43:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/12763002/19002

[commit-bot: I haz the power, 2013-03-12 01:13:46]

Change committed as 187441