Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

Issue 1276273003: suggest import uris when import is only text in file (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
index 6cbfb014ee2f966fffed9d4c5bc626ccc2bb925a..55e9c0d11fc295565164fdb8c97c6b34a3fead49 100644
--- a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
@@ -203,7 +203,12 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
_addSuggestion(Keyword.DEFERRED, DART_RELEVANCE_HIGH);
}
}
- if (entity == node.semicolon || node.combinators.contains(entity)) {
+ // Handle degenerate case where import statement does not have a semicolon
+ // and the cursor is in the uri string
+ if ((entity == node.semicolon &&
+ node.uri != null &&
+ node.uri.offset + 1 != request.offset) ||
+ node.combinators.contains(entity)) {
_addImportDirectiveKeywords(node);
}
}

Powered by Google App Engine
This is Rietveld 408576698