Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1276273002: [es6] Fix parsing of expressions in parameter lists (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev, caitpotter88_chromium.org
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix parsing of expressions in patterns Fixes the use of eval calls in strict parameter lists in particular. R=adamk@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/73ae23b5dc9bd816474688e74b9b768a09b9711f Cr-Commit-Position: refs/heads/master@{#30074}

Patch Set 1 #

Patch Set 2 : Whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -89 lines) Patch
M src/expression-classifier.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/preparser.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 7 chunks +82 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 4 months ago (2015-08-07 12:15:33 UTC) #1
adamk
lgtm
5 years, 4 months ago (2015-08-07 17:16:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276273002/20001
5 years, 4 months ago (2015-08-07 21:17:27 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 21:55:50 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 21:56:09 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73ae23b5dc9bd816474688e74b9b768a09b9711f
Cr-Commit-Position: refs/heads/master@{#30074}

Powered by Google App Engine
This is Rietveld 408576698