Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 1276263002: Add resource tests. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 2304b5c5479e8ddd7c8ca8b310c5d39daddb2be4..d16474c18d77ca486fe243f14e282abde6d57bb1 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -879,6 +879,12 @@ class StandardTestSuite extends TestSuite {
var expectLinkTarget = TestUtils.dartDir
.append('pkg').append('expect').append('lib');
+ // NOTE: We make a link in the package-root to pkg/package_test_data,
+ // since 'package:package_test_data' is not available on pub.dartlang.org!
+ var testDataLink = newPackageRoot.append('package_test_data');
+ var testDataLinkTarget = TestUtils.dartDir
+ .append('pkg').append('package_test_data').append('lib');
+
Lasse Reichstein Nielsen 2015/08/10 10:41:51 Is this actually necessary?
Bill Hesse 2015/08/10 11:37:43 No, this is not needed. Only those tests that are
// Generate dependency overrides if we use repository packages.
var packageDirectories = {};
if (configuration['use_repository_packages']) {
@@ -901,6 +907,8 @@ class StandardTestSuite extends TestSuite {
}
commands.add(CommandBuilder.instance.getMakeSymlinkCommand(
expectLink.toNativePath(), expectLinkTarget.toNativePath()));
+ commands.add(CommandBuilder.instance.getMakeSymlinkCommand(
+ testDataLink.toNativePath(), testDataLinkTarget.toNativePath()));
Bill Hesse 2015/08/10 11:37:43 Also not needed.
return {
'commands' : commands,
« pkg/package_test_data/pubspec.yaml ('K') | « tests/corelib/package_resource_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698