Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1276243002: Oilpan: mark StylePropertySet::PropertyReference as stack allocated. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: mark StylePropertySet::PropertyReference as stack allocated. Annotate this object as stack allocated + turn its StylePropertySet reference into a Member. R=haraken BUG=509911 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M Source/core/css/StylePropertySet.h View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-07 10:57:53 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-07 13:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276243002/1
5 years, 4 months ago (2015-08-07 13:19:33 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 14:26:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200169

Powered by Google App Engine
This is Rietveld 408576698