Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276203004: Implement FormData::isSafeToSendToAnotherThread() (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement FormData::isSafeToSendToAnotherThread() This will be used in https://codereview.chromium.org/1265413002/. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200316

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Use range-based for. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M Source/platform/network/FormData.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/platform/network/FormData.cpp View 1 2 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276203004/1
5 years, 4 months ago (2015-08-11 10:13:00 UTC) #2
hiroshige
PTAL.
5 years, 4 months ago (2015-08-11 10:21:32 UTC) #4
haraken
Would you add some CL description? Where will the isSafeToSendToAnotherThread() be used? https://codereview.chromium.org/1276203004/diff/20001/Source/platform/network/FormData.cpp File Source/platform/network/FormData.cpp ...
5 years, 4 months ago (2015-08-11 10:58:45 UTC) #5
hiroshige
https://codereview.chromium.org/1276203004/diff/20001/Source/platform/network/FormData.cpp File Source/platform/network/FormData.cpp (right): https://codereview.chromium.org/1276203004/diff/20001/Source/platform/network/FormData.cpp#newcode202 Source/platform/network/FormData.cpp:202: for (size_t i = 0; i < n; ++i) ...
5 years, 4 months ago (2015-08-11 11:20:28 UTC) #6
haraken
LGTM
5 years, 4 months ago (2015-08-11 11:21:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276203004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276203004/40001
5 years, 4 months ago (2015-08-11 11:22:31 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 13:27:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200316

Powered by Google App Engine
This is Rietveld 408576698