Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: Source/core/animation/InterpolationValue.h

Issue 1276183004: Oilpan: Unship oilpan from temporary animation objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/InterpolationValue.h
diff --git a/Source/core/animation/InterpolationValue.h b/Source/core/animation/InterpolationValue.h
index a2d7b0ff83562a873a86e2dd9af361032403b558..3479fa0203716ad53a30a43fbb89f44b8f4103fc 100644
--- a/Source/core/animation/InterpolationValue.h
+++ b/Source/core/animation/InterpolationValue.h
@@ -13,14 +13,14 @@ namespace blink {
class InterpolationType;
-class InterpolationValue : public NoBaseWillBeGarbageCollectedFinalized<InterpolationValue> {
+class InterpolationValue {
public:
- static PassOwnPtrWillBeRawPtr<InterpolationValue> create(const InterpolationType& type, PassOwnPtrWillBeRawPtr<InterpolableValue> interpolableValue, PassRefPtrWillBeRawPtr<NonInterpolableValue> nonInterpolableValue = nullptr)
+ static PassOwnPtr<InterpolationValue> create(const InterpolationType& type, PassOwnPtr<InterpolableValue> interpolableValue, PassRefPtrWillBeRawPtr<NonInterpolableValue> nonInterpolableValue = nullptr)
{
- return adoptPtrWillBeNoop(new InterpolationValue(type, interpolableValue, nonInterpolableValue));
+ return adoptPtr(new InterpolationValue(type, interpolableValue, nonInterpolableValue));
}
- PassOwnPtrWillBeRawPtr<InterpolationValue> clone() const
+ PassOwnPtr<InterpolationValue> clone() const
{
return create(m_type, m_interpolableValue->clone(), m_nonInterpolableValue);
}
@@ -30,14 +30,8 @@ public:
InterpolableValue& interpolableValue() { return *m_interpolableValue; }
const NonInterpolableValue* nonInterpolableValue() const { return m_nonInterpolableValue.get(); }
- DEFINE_INLINE_TRACE()
- {
- visitor->trace(m_interpolableValue);
- visitor->trace(m_nonInterpolableValue);
- }
-
private:
- InterpolationValue(const InterpolationType& type, PassOwnPtrWillBeRawPtr<InterpolableValue> interpolableValue, PassRefPtrWillBeRawPtr<NonInterpolableValue> nonInterpolableValue = nullptr)
+ InterpolationValue(const InterpolationType& type, PassOwnPtr<InterpolableValue> interpolableValue, PassRefPtrWillBeRawPtr<NonInterpolableValue> nonInterpolableValue = nullptr)
: m_type(type)
, m_interpolableValue(interpolableValue)
, m_nonInterpolableValue(nonInterpolableValue)
@@ -46,8 +40,8 @@ private:
}
const InterpolationType& m_type;
- OwnPtrWillBeMember<InterpolableValue> m_interpolableValue;
- RefPtrWillBeMember<NonInterpolableValue> m_nonInterpolableValue;
+ OwnPtr<InterpolableValue> m_interpolableValue;
+ RefPtrWillBePersistent<NonInterpolableValue> m_nonInterpolableValue;
friend class InterpolationType;
};

Powered by Google App Engine
This is Rietveld 408576698