Issue 1276173003: Revert of Move GrDrawAtlasBatch to separate file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276173003: Revert of Move GrDrawAtlasBatch to separate file (Closed)

Created:
5 years, 4 months ago by jvanverth1

Modified:
5 years, 4 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@drawAtlas-08-06

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Move GrDrawAtlasBatch to separate file (patchset #1 id:1 of https://codereview.chromium.org/1274013003/ ) Reason for revert: Build failures Original issue's description: > Move GrDrawAtlasBatch to separate file > > Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1694a936f65cc53729affe18c17497af821cc262

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -292 lines)			Patch
M	gyp/gpu.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	src/gpu/GrDrawAtlasBatch.h	View	1 chunk	+0 lines, -75 lines	0 comments	Download
D	src/gpu/GrDrawAtlasBatch.cpp	View	1 chunk	+0 lines, -211 lines	0 comments	Download
M	src/gpu/GrDrawContext.cpp	View	3 chunks	+164 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

Created Revert of Move GrDrawAtlasBatch to separate file

5 years, 4 months ago (2015-08-07 18:53:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276173003/1

5 years, 4 months ago (2015-08-07 18:53:10 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-07 18:53:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1694a936f65cc53729affe18c17497af821cc262

Expand Messages | Collapse Messages