Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1276163002: Revert of Sandbox html_viewer on Linux. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
jam, Elliot Glaysher
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, penghuang+watch-mandoline_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sandbox html_viewer on Linux. (patchset #6 id:100001 of https://codereview.chromium.org/1274743004/ ) Reason for revert: Doesn't build on the Linux GN bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/30188/steps/compile/logs/stdio Original issue's description: > Sandbox html_viewer on Linux. > > This creates a font_service which does the same role as > font_config_ipc_linux.cc does in content/. This lets us sandbox the > html_viewer, while still being able to communicate with fontconfig. > > Also prewarms the ICU timezone data, along with doing all the > prewarming that's done in the core_services sandbox. > > BUG=492524 > NOPRESUBMIT=true > > Committed: https://crrev.com/4196dfefc131b0a77a3e02e917b852dba8faf445 > Cr-Commit-Position: refs/heads/master@{#342281} TBR=jam@chromium.org,erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492524 Committed: https://crrev.com/0001770c500d61c7369860cfef9353576dd30a3b Cr-Commit-Position: refs/heads/master@{#342286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -865 lines) Patch
D components/font_service/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D components/font_service/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/font_service/font_service_app.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/font_service/font_service_app.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D components/font_service/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/font_service/public/cpp/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D components/font_service/public/cpp/font_loader.h View 1 chunk +0 lines, -67 lines 0 comments Download
D components/font_service/public/cpp/font_loader.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D components/font_service/public/cpp/font_service_thread.h View 1 chunk +0 lines, -97 lines 0 comments Download
D components/font_service/public/cpp/font_service_thread.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D components/font_service/public/cpp/mapped_font_file.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/font_service/public/cpp/mapped_font_file.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D components/font_service/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/font_service/public/interfaces/font_service.mojom View 1 chunk +0 lines, -38 lines 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -9 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/global_state.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/html_viewer/html_viewer_main.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/runner/linux_sandbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Sandbox html_viewer on Linux.
5 years, 4 months ago (2015-08-07 04:49:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276163002/1
5 years, 4 months ago (2015-08-07 04:49:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 04:51:03 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 04:51:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0001770c500d61c7369860cfef9353576dd30a3b
Cr-Commit-Position: refs/heads/master@{#342286}

Powered by Google App Engine
This is Rietveld 408576698