Issue 127613002: google_apis: Stop accessing URLFetcher from ResponseWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127613002: google_apis: Stop accessing URLFetcher from ResponseWriter (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Stop accessing URLFetcher from ResponseWriter To fix use-after-free BUG=331822 TEST=See no crash after following the repro steps described in the BUG. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243531

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -19 lines)			Patch
	M	google_apis/drive/base_requests.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
	M	google_apis/drive/base_requests.cc	View		4 chunks	+36 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hashimoto

This should be a more appropriate fix than https://codereview.chromium.org/127463002/. PTL.

6 years, 11 months ago (2014-01-08 05:20:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/127613002/50001

6 years, 11 months ago (2014-01-08 07:25:56 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=211137

6 years, 11 months ago (2014-01-08 08:31:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/127613002/50001

6 years, 11 months ago (2014-01-08 08:42:53 UTC) #5

Message was sent while issue was closed.

Change committed as 243531

Expand Messages | Collapse Messages