Issue 12761003: Revert 187233

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12761003: Revert 187233 (Closed)

Created:
7 years, 9 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
7 years, 9 months ago

Reviewers:
jeremya

CC:
chromium-reviews, darin-cc_chromium.org, jam, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 187233 > Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket. > > IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate > when a client connects. The delegate is expected to craft an IPC::Channel from > the handle it is given. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 > > Review URL: https://chromiumcodereview.appspot.com/12386010 TBR=jeremya@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187240

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -636 lines)			Patch
M	ipc/ipc.gyp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	ipc/ipc.gypi	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	ipc/ipc_channel.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	ipc/ipc_channel_factory.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	ipc/ipc_channel_factory.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	ipc/ipc_channel_posix.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	7 chunks	+170 lines, -19 lines	0 comments	Download
M	ipc/ipc_channel_posix_unittest.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	ipc/ipc_channel_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	ipc/unix_domain_socket_util.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	ipc/unix_domain_socket_util.cc	View	1 chunk	+0 lines, -202 lines	0 comments	Download
D	ipc/unix_domain_socket_util_unittest.cc	View	1 chunk	+0 lines, -178 lines	0 comments	Download

Total messages: 2 (0 generated)

Dai Mikurube (NOT FULLTIME)

7 years, 9 months ago (2013-03-11 06:17:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r187240.