Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276093002: Add material design assets for omnibox (Closed)

Created:
5 years, 4 months ago by tdanderson
Modified:
5 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add material design assets for omnibox Adding some material design assets in chrome/app/theme to be used for the omnibox. BUG=505803, 495654 TEST=none NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/25746cbaa1391d5b11a32f15befc430d03f2be99 Cr-Commit-Position: refs/heads/master@{#342344}

Patch Set 1 #

Patch Set 2 : crush #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/material_100_percent/common/browser_tools_normal.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/controlled_setting_mandatory.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/keyword_hint_tab.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_https_invalid.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_https_valid.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_https_warning.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/omnibox_mic_search.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_search_secured.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_star.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_tts.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/save_password_active.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/save_password_inactive.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/star.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/star_lit.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/zoom_minus.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/zoom_plus.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/common/zoom_reset.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/pdf.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/translate.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_100_percent/translate_active.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/browser_tools_normal.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/controlled_setting_mandatory.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/keyword_hint_tab.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_https_invalid.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_https_valid.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_https_warning.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/omnibox_mic_search.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_search_secured.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_star.png View 1 Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_tts.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/save_password_active.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/save_password_inactive.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/star.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/star_lit.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/zoom_minus.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/zoom_plus.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/common/zoom_reset.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/pdf.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/translate.png View 1 Binary file 0 comments Download
M chrome/app/theme/material_200_percent/translate_active.png View 1 Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
oshima@, can you PTAL?
5 years, 4 months ago (2015-08-06 22:37:15 UTC) #2
oshima
lgtm
5 years, 4 months ago (2015-08-07 07:58:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276093002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276093002/2
5 years, 4 months ago (2015-08-07 13:50:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 4 months ago (2015-08-07 13:51:20 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:51:54 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25746cbaa1391d5b11a32f15befc430d03f2be99
Cr-Commit-Position: refs/heads/master@{#342344}

Powered by Google App Engine
This is Rietveld 408576698