tracing/tracing/model/stack_frame.html - Issue 1276003004: Process v8 sampling data into the trace model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/model/stack_frame.html

Issue 1276003004: Process v8 sampling data into the trace model. (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/model/stack_frame.html

diff --git a/tracing/tracing/model/stack_frame.html b/tracing/tracing/model/stack_frame.html

index b10d3f01a35d1c188aab981c22ce4bb1f1860c43..af676b5ee47d5e5135edab5bec694d31d6ebdca3 100644

--- a/tracing/tracing/model/stack_frame.html

+++ b/tracing/tracing/model/stack_frame.html

@@ -31,8 +31,10 @@ tr.exportTo('tr.model', function() {

get title() {

- if (this.sourceInfo_)

- return this.title_ + ' ' + this.sourceInfo_.toString();

+ if (this.sourceInfo_) {

+ var src = this.sourceInfo_.toString();

+ return this.title_ + (src === '' ? '' : ' ' + src);

+ }

return this.title_;