Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: tracing/tracing/model/stack_frame.html

Issue 1276003004: Process v8 sampling data into the trace model. (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/stack_frame.html
diff --git a/tracing/tracing/model/stack_frame.html b/tracing/tracing/model/stack_frame.html
index b10d3f01a35d1c188aab981c22ce4bb1f1860c43..f0e2ebdb858a71785df467afcc1a21410e933df0 100644
--- a/tracing/tracing/model/stack_frame.html
+++ b/tracing/tracing/model/stack_frame.html
@@ -31,8 +31,11 @@ tr.exportTo('tr.model', function() {
},
get title() {
- if (this.sourceInfo_)
- return this.title_ + ' ' + this.sourceInfo_.toString();
+ if (this.sourceInfo_) {
+ var src = this.sourceInfo_.toString();
+
petrcermak 2015/08/12 10:53:24 personal taste (feel free to ignore): I would drop
dsinclair 2015/08/13 14:55:33 Done.
+ return this.title_ + (src === '' ? '' : ' ' + src);
+ }
return this.title_;
},

Powered by Google App Engine
This is Rietveld 408576698