Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 12760007: [chromedriver] Move the new chromedriver java tests to use the server. (Closed)

Created:
7 years, 9 months ago by craigdh
Modified:
7 years, 9 months ago
Reviewers:
kkania, frankf
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Move the new chromedriver java tests to use the server. Previously it was using the shared library. Also adds support for passing an android-package parameter to run_java_tests.py that gets passed on to the ChromeDriver server as a capability. NOTRY=True BUG=chromedriver:215 TEST=This is a test... Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189486

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -138 lines) Patch
M patch.diff View 1 2 3 1 chunk +49 lines, -138 lines 0 comments Download
M test-standalone.jar View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
craigdh
7 years, 9 months ago (2013-03-20 23:20:59 UTC) #1
kkania
lgtm if passes https://codereview.chromium.org/12760007/diff/3001/patch.diff File patch.diff (right): https://codereview.chromium.org/12760007/diff/3001/patch.diff#newcode18 patch.diff:18: --- java/client/src/org/openqa/selenium/chrome/ChromeOptions.java (revision 18456) if you're ...
7 years, 9 months ago (2013-03-20 23:23:45 UTC) #2
craigdh
https://codereview.chromium.org/12760007/diff/3001/patch.diff File patch.diff (right): https://codereview.chromium.org/12760007/diff/3001/patch.diff#newcode18 patch.diff:18: --- java/client/src/org/openqa/selenium/chrome/ChromeOptions.java (revision 18456) On 2013/03/20 23:23:45, kkania wrote: ...
7 years, 9 months ago (2013-03-21 00:04:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/12760007/11001
7 years, 9 months ago (2013-03-21 01:40:08 UTC) #4
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 9 months ago (2013-03-21 01:40:09 UTC) #5
craigdh
7 years, 9 months ago (2013-03-21 01:41:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r189486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698