Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1275983003: Subzero: Fix szbuild.py linking. (Closed)

Created:
5 years, 4 months ago by Jim Stichnoth
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix szbuild.py linking. The symbol __Sz_block_profile_info needs to be explicitly globalized when combining llc and Subzero .o output, i.e. when the --include or --exclude options are used. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=88ab5ca48564f4863d71f43bdfe0f1104e038ece

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pydir/szbuild.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 4 months ago (2015-08-06 21:12:38 UTC) #2
John
lgtm
5 years, 4 months ago (2015-08-06 21:18:31 UTC) #3
native-client-reviews_googlegroups.com
This script works. On Thu, Aug 6, 2015 at 2:18 PM, <jpp@chromium.org> wrote: > lgtm ...
5 years, 4 months ago (2015-08-06 21:19:31 UTC) #4
Jim Stichnoth
5 years, 4 months ago (2015-08-06 21:56:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88ab5ca48564f4863d71f43bdfe0f1104e038ece (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698