Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1275983002: Restat shared library link ops in GN on Windows. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restat shared library link ops in GN on Windows. The lack of this is causing unnecessary rebuilds when changes in a source file affect the .dll but not the .lib. This restat flag addition matches GYP on Windows and how GN on Posix work. Committed: https://crrev.com/ded08d3c535fa0c4b0951e99ef9d1ac656f55826 Cr-Commit-Position: refs/heads/master@{#342148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/toolchain/win/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 4 months ago (2015-08-06 17:52:07 UTC) #2
scottmg
lgtm
5 years, 4 months ago (2015-08-06 17:53:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275983002/1
5 years, 4 months ago (2015-08-06 17:55:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 18:26:29 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 18:27:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded08d3c535fa0c4b0951e99ef9d1ac656f55826
Cr-Commit-Position: refs/heads/master@{#342148}

Powered by Google App Engine
This is Rietveld 408576698