Service Worker: Stop using a scoped_ptr for an object to be released immediately.

Service Worker: Stop using a scoped_ptr for an object to be released immediately.

The original code of the callers of WebCallbacks::onError/onSuccess methods
addressed by this CL create a scoped_ptr and immediately release it to pass a
raw pointer to method. This CL changes it to directly use a raw pointer.

Related comment from nhiroki@: https://codereview.chromium.org/1270513002/diff/20001/content/child/service_worker/service_worker_dispatcher.cc#newcode562

BUG=N/A

Committed: https://crrev.com/bdcc0660980f5eb4e0bf09000cc6e75e699c5759
Cr-Commit-Position: refs/heads/master@{#342804}

[jungkees, 2015-08-10 06:59:49]

jungkee.song@samsung.com changed reviewers:
+ jinho.bang@samsung.com, l.gombos@samsung.com

[jungkees, 2015-08-10 07:08:57]

I've tried to remove unnecessary creation/use of scoped_ptr objects in
service_worker_dispatcher.cc. PTAL.

[zino, 2015-08-11 06:47:44]

On 2015/08/10 07:08:57, jungkees wrote:
> I've tried to remove unnecessary creation/use of scoped_ptr objects in
> service_worker_dispatcher.cc. PTAL.

looks good to me.

[jungkees, 2015-08-11 06:51:48]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, michaeln@chromium.org,
nhiroki@chromium.org

[jungkees, 2015-08-11 06:52:38]

Thanks for the peer review, zino@. PTAL.

[nhiroki, 2015-08-11 07:42:17]

Thank you for working on this. LGTM

nit: The CL subject could be a bit confusing because the original code passes
not a scoped_ptr but a released raw_ptr. Could you make it clearer? (for
example, "Stop using a scoped_ptr for an object to be released immediately")

[jungkees, 2015-08-11 08:03:17]

Fair point! Thanks for the comment.

[jungkees, 2015-08-11 08:22:27]

The CQ bit was checked by jungkee.song@samsung.com

[commit-bot: I haz the power, 2015-08-11 08:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275903003/1

[jungkees, 2015-08-11 09:12:54]

The CQ bit was unchecked by jungkee.song@samsung.com

[jungkees, 2015-08-11 09:13:23]

The CQ bit was checked by jungkee.song@samsung.com

[commit-bot: I haz the power, 2015-08-11 09:13:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275903003/1

[commit-bot: I haz the power, 2015-08-11 10:22:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-11 10:22:43]

Patchset 1 (id:??) landed as
https://crrev.com/bdcc0660980f5eb4e0bf09000cc6e75e699c5759
Cr-Commit-Position: refs/heads/master@{#342804}