Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1275893002: [PresentationAPI, Android] Add ChromeMediaRouter.java and bind it with the native MediaRouterAndroid (Closed)

Created:
5 years, 4 months ago by whywhat
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PresentationAPI, Android] Add ChromeMediaRouter.java and bind it with the native MediaRouterAndroid BUG=512549 NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/dfd96bfb4fd382044a96d715f0cab9824c5d457c Cr-Commit-Position: refs/heads/master@{#342392}

Patch Set 1 #

Patch Set 2 : Removed impl from the names #

Patch Set 3 : Formatting #

Patch Set 4 : Removed CHECK, changed intptr_t to jlong #

Patch Set 5 : fix failiing DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 1 1 chunk +32 lines, -0 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/media/android/router/media_router_android.h View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (8 generated)
whywhat
PTaL!
5 years, 4 months ago (2015-08-06 14:07:50 UTC) #2
whywhat
Removed CHECK, changed intptr_t to jlong
5 years, 4 months ago (2015-08-06 16:36:06 UTC) #3
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-08-06 16:37:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275893002/60001
5 years, 4 months ago (2015-08-06 16:38:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/52761)
5 years, 4 months ago (2015-08-06 22:41:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275893002/60001
5 years, 4 months ago (2015-08-07 09:41:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275893002/80001
5 years, 4 months ago (2015-08-07 15:40:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/90466)
5 years, 4 months ago (2015-08-07 16:52:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275893002/80001
5 years, 4 months ago (2015-08-07 18:31:13 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-07 18:37:42 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:38:23 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/dfd96bfb4fd382044a96d715f0cab9824c5d457c
Cr-Commit-Position: refs/heads/master@{#342392}

Powered by Google App Engine
This is Rietveld 408576698