Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1275853003: net/testserver.py: Add handler to reply with client auth status. (Closed)

Created:
5 years, 4 months ago by pneubeck (no reviews)
Modified:
5 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net/testserver.py: Add handler to reply with client auth status. BUG=514575 Committed: https://crrev.com/1300c883029570b4ab83ac12e340e9500e54c7e3 Cr-Commit-Position: refs/heads/master@{#342337}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reply with certificate fingerprint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M net/tools/testserver/testserver.py View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pneubeck (no reviews)
separated from the larger CL. ptal
5 years, 4 months ago (2015-08-06 08:58:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275853003/1
5 years, 4 months ago (2015-08-06 09:22:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-06 09:30:16 UTC) #6
Ryan Sleevi
Pre-emptive LGTM, but I have a design suggestion change for how you're signalling the client ...
5 years, 4 months ago (2015-08-06 23:48:52 UTC) #7
pneubeck (no reviews)
https://codereview.chromium.org/1275853003/diff/1/net/tools/testserver/testserver.py File net/tools/testserver/testserver.py (right): https://codereview.chromium.org/1275853003/diff/1/net/tools/testserver/testserver.py#newcode1530 net/tools/testserver/testserver.py:1530: self.wfile.write('got no client cert') On 2015/08/06 23:48:52, Ryan Sleevi ...
5 years, 4 months ago (2015-08-07 11:47:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275853003/20001
5 years, 4 months ago (2015-08-07 11:48:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 11:55:18 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 11:56:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1300c883029570b4ab83ac12e340e9500e54c7e3
Cr-Commit-Position: refs/heads/master@{#342337}

Powered by Google App Engine
This is Rietveld 408576698