Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 127583002: Separate EmbeddedWorker messages into another file to use different msg class (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, alecflett, michaeln
Visibility:
Public.

Description

Separate EmbeddedWorker messages into another file to use different msg class So that we can rely on IPC_MESSAGE_CLASS(msg) check to determine which messages we want to relay onto another thread. Mostly just shuffling, - Separated EmbeddedWorker messages out of service_worker_messages.h into embedded_worker_messages.h - Added a new message class for that - Created a new directory content/common/service_worker (and OWNERS file) as now we have multiple header files for SW under common/ BUG=313530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243871

Patch Set 1 #

Patch Set 2 : split the message file into two #

Patch Set 3 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -219 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + content/common/service_worker/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A content/common/service_worker/embedded_worker_messages.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A + content/common/service_worker/service_worker_messages.h View 1 2 chunks +0 lines, -41 lines 0 comments Download
A + content/common/service_worker/service_worker_types.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/service_worker/service_worker_types.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/common/service_worker_messages.h View 1 1 chunk +0 lines, -102 lines 0 comments Download
D content/common/service_worker_types.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
D content/common/service_worker_types.cc View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
Tom, (cc: alecf/michaeln) Could you review this tiny IPC change? It turned out I want ...
6 years, 11 months ago (2014-01-08 03:57:55 UTC) #1
Tom Sepez
On 2014/01/08 03:57:55, kinuko wrote: > Tom, (cc: alecf/michaeln) > > Could you review this ...
6 years, 11 months ago (2014-01-08 20:09:33 UTC) #2
kinuko
We could break this into multiple files, or check the specific message types in thread ...
6 years, 11 months ago (2014-01-08 23:48:20 UTC) #3
Tom Sepez
Probably cleaner to make a new file, if it's not too much trouble. LGTM otherwise.
6 years, 11 months ago (2014-01-09 00:05:42 UTC) #4
kinuko
Added a new file embedded_worker_messages.h out of service_worker_messages.h, and created a new sub-dir content/common/service_worker to ...
6 years, 11 months ago (2014-01-09 04:48:35 UTC) #5
Avi (use Gerrit)
Cool. LGTM
6 years, 11 months ago (2014-01-09 04:53:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/127583002/470001
6 years, 11 months ago (2014-01-09 10:31:57 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:42:48 UTC) #8
Message was sent while issue was closed.
Change committed as 243871

Powered by Google App Engine
This is Rietveld 408576698