chrome/renderer/spellchecker/spellcheck.cc - Issue 1275813002: Implemented typo recognition in Chrome for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck.cc

Issue 1275813002: Implemented typo recognition in Chrome for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@4_remove_mac_redundancies

Patch Set: Changed pending requests to be handled in native, other comment addressing Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spellchecker_session_bridge_android.cc ('K') | « chrome/renderer/spellchecker/spellcheck.h ('k') | chrome/renderer/spellchecker/spellcheck_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/spellchecker/spellcheck.cc

diff --git a/chrome/renderer/spellchecker/spellcheck.cc b/chrome/renderer/spellchecker/spellcheck.cc

index e3543547497f8790d125916d9a7422abd258d205..89f6ffcd3746923ec5b04c606819c0f484d8837a 100644

--- a/chrome/renderer/spellchecker/spellcheck.cc

+++ b/chrome/renderer/spellchecker/spellcheck.cc

@@ -8,10 +8,12 @@

#include "base/basictypes.h"

#include "base/bind.h"

+#include "base/command_line.h"

#include "base/location.h"

#include "base/logging.h"

#include "base/single_thread_task_runner.h"

#include "base/thread_task_runner_handle.h"

+#include "chrome/common/chrome_switches.h"

#include "chrome/common/spellcheck_common.h"

#include "chrome/common/spellcheck_messages.h"

#include "chrome/common/spellcheck_result.h"

@@ -477,3 +479,13 @@ void SpellCheck::CreateTextCheckingResults(

textcheck_results->assign(results);

}

+bool SpellCheck::IsSpellcheckEnabled() {

+#if defined(OS_ANDROID)

+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kEnableAndroidSpellChecker)) {

+ return false;

+ }

+#endif

+ return spellcheck_enabled_;