Implemented typo recognition in Chrome for Android.

chrome/browser/spellchecker/spellchecker_session_bridge_android.h

Index: chrome/browser/spellchecker/spellchecker_session_bridge_android.h
diff --git a/chrome/browser/spellchecker/spellchecker_session_bridge_android.h b/chrome/browser/spellchecker/spellchecker_session_bridge_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..41cf67bac5bdac24d20ce580ddf11a202a23df38
--- /dev/null
+++ b/chrome/browser/spellchecker/spellchecker_session_bridge_android.h
@@ -0,0 +1,32 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_H_
+#define CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_H_
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
+#include "base/android/jni_string.h"
+
+class SpellCheckerSessionBridge {

[please use gerrit instead, 2015/08/11 16:43:47]

Some docs on class and methods would not hurt.

[dylanking, 2015/08/12 01:29:55]

Agreed, done.

+ public:
+  SpellCheckerSessionBridge(int render_process_id);

[please use gerrit instead, 2015/08/11 16:43:47]

Mark this constructor explicit to avoid implicit conversion from an int to this
object.

[please use gerrit instead, 2015/08/11 16:43:47]

If you have a constructor, you should have a destructor.

[dylanking, 2015/08/12 00:16:27]

Done.

+  void RequestTextCheck(int route_id,
+                        int identifier,
+                        const base::string16& text);
+  static bool RegisterSpellCheckerSessionBridge(JNIEnv* env);

[please use gerrit instead, 2015/08/11 16:43:47]

Static methods should be right after constructor/destructor pair.

[dylanking, 2015/08/12 01:29:55]

Done.

+  void GetSpellcheckInfo(JNIEnv* env,

[please use gerrit instead, 2015/08/11 16:43:47]

s/GetSpellcheckInfo/ProcessSpellcheckResults/

[dylanking, 2015/08/12 01:29:55]

Done, though I capitalized the C in "Spellcheck" to be more consistent with
surrounding code.

+                         jobject jobj,
+                         jstring text,
+                         jintArray offsetArray,
+                         jintArray lengthArray);
+
+ private:
+  int render_process_id_;
+  int route_id_;

[please use gerrit instead, 2015/08/11 16:43:47]

What is the difference between render_process_id_ and route_id_?

[dylanking, 2015/08/12 01:29:55]

I'm not entirely sure.  render_process_id seems to be associated with the
MessageFilter, whereas a route_id is associated with a specific IPC
SpellCheckMessage.  

I have encapsulated some logic so that the route_id's get directly forwarded to
the Java side and not stored in the C++ side, along with the other information
contained in each specific message.

+  int identifier_;
+  base::android::ScopedJavaGlobalRef<jobject> java_object_;
+};

[please use gerrit instead, 2015/08/11 16:43:47]

DISALLOW_COPY_AND_ASSIGN(SpellCheckerSessionBridge);

[dylanking, 2015/08/12 01:29:55]

Done.

+
+#endif

[please use gerrit instead, 2015/08/11 16:43:47]

#endif  //  CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_H_

[dylanking, 2015/08/12 01:29:55]

Done.