chrome/browser/spellchecker/spellcheck_message_filter_platform.h - Issue 1275813002: Implemented typo recognition in Chrome for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_platform.h

Issue 1275813002: Implemented typo recognition in Chrome for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@4_remove_mac_redundancies

Patch Set: Removed unused variables from past implementation approach Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/spellchecker/SpellCheckerSessionBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/spellchecker/SpellCheckerSessionBridge.java ('k') | chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc » ('j') | chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter_platform.h

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform.h b/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

index a632112734b42457585b725c12f53d7b976d3a3a..18fde140df180445f607ae197fa16110c3155954 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

@@ -8,6 +8,7 @@

#include <map>

#include "chrome/browser/spellchecker/spellcheck_message_filter.h"

+#include "chrome/browser/spellchecker/spellchecker_session_bridge_android.h"

please use gerrit instead 2015/08/11 16:43:46 Forward declare SpellCheckerSessionBridge instead

dylanking 2015/08/12 01:29:55 Done, after some struggle.

#include "chrome/common/spellcheck_result.h"

#include "content/public/browser/browser_message_filter.h"

@@ -51,6 +52,7 @@ class SpellCheckMessageFilterPlatform : public content::BrowserMessageFilter {

int render_process_id_;

+ scoped_ptr<SpellCheckerSessionBridge> impl_;

please use gerrit instead 2015/08/11 16:43:46 Add a comment that this implementation detail is u

dylanking 2015/08/12 00:16:27 Done.

// A JSON-RPC client that calls the Spelling service in the background.

scoped_ptr<SpellingServiceClient> client_;