Implemented typo recognition in Chrome for Android.

chrome/browser/spellchecker/spellchecker_session_bridge_android.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_
+#define CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/string16.h"
+
+// Owned by the SpellCheckMessageFilterPlatform.  This class is used to

[please use gerrit instead, 2015/08/17 21:29:46]

Ownership of this class is not something that this class controls. If ownership
of this class will change, then no one will bother to update this comment.
Please remove it.

[dylanking, 2015/08/18 01:21:31]

Done!  Good point, thanks.

+// interface between the android message filter and the Java class of the
+// same name.  This class is sent text to be spellchecked from
+// the message filter, then sends that text to the Java side via JNI to be
+// spellchecked, and finally processes those results and sends them to the

[please use gerrit instead, 2015/08/17 21:29:46]

You're using the Oxford comma in some places, but not in others. This can be
jarring to some readers. Please pick one style and stick with it.

[dylanking, 2015/08/18 01:21:31]

Reworded the comment a bit to avoid this. Thanks.

+// renderer.
+class SpellCheckerSessionBridge {
+ public:
+  explicit SpellCheckerSessionBridge(int render_process_id);
+  ~SpellCheckerSessionBridge();
+  static bool RegisterJNI(JNIEnv* env);
+
+  // Receives text to be checked from the message filter and sends it to Java
+  // to be spellchecked.
+  void RequestTextCheck(int route_id,
+                        int identifier,
+                        const base::string16& text);
+
+  // Receives information from Java side about the typos in a given string
+  // of text, processes these and sends them to the renderer.
+  void ProcessSpellCheckResults(JNIEnv* env,
+                                jobject jobj,
+                                jintArray offset_array,
+                                jintArray length_array);
+
+ private:
+  struct SpellingRequest {

[please use gerrit instead, 2015/08/17 21:29:46]

nit: You /could/ forward declare this to relieve the burden from the reader and
save a few milliseconds during the compile time. Not too important, though.

[dylanking, 2015/08/18 01:21:31]

Let's leave it in here for now.

+    SpellingRequest(int route_id, int identifier, const base::string16& text);
+    ~SpellingRequest() {}

[please use gerrit instead, 2015/08/17 21:29:46]

Let's not inline destructors. Technically, inline destructors are OK for simple
objects, but I have my doubts about simplicity of base::string16 and whatever
else might creep into this object eventually.

[dylanking, 2015/08/18 01:21:31]

Alright, moved to the .cc file.

+
+    int route_id;
+    int identifier;
+    base::string16 text;
+  };
+
+  int render_process_id_;
+
+  scoped_ptr<SpellingRequest> active_request_;
+  scoped_ptr<SpellingRequest> pending_request_;
+
+  base::android::ScopedJavaGlobalRef<jobject> java_object_;
+
+  DISALLOW_COPY_AND_ASSIGN(SpellCheckerSessionBridge);
+};
+
+#endif  // CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_