Implemented typo recognition in Chrome for Android.

chrome/browser/spellchecker/spellchecker_session_bridge_android.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/spellchecker/spellchecker_session_bridge_android.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
+#include "base/android/jni_string.h"

[please use gerrit instead, 2015/08/11 16:43:46]

Chromium style is to not repeat header's includes in the source file.

[dylanking, 2015/08/12 01:29:55]

Shouldn't have let that slip through. Thanks.

+#include "chrome/common/spellcheck_messages.h"
+#include "chrome/common/spellcheck_result.h"
+#include "content/public/browser/render_process_host.h"
+#include "jni/SpellCheckerSessionBridge_jni.h"
+
+SpellCheckerSessionBridge::SpellCheckerSessionBridge(int render_process_id)
+    : render_process_id_(render_process_id) {

[please use gerrit instead, 2015/08/11 16:43:46]

Will this work?

SpellCheckerSessionBridge::SpellCheckerSessionBridge(int render_process_id)
    : render_process_id_(render_process_id),
      java_object_(Java_SpellCheckerSessionBridge_create(
          base::android::AttachCurrentThread(),
          reinterpret_cast<intptr_t>(this))) {}

[dylanking, 2015/08/12 01:29:55]

Yes! Reset() was the only assignment operator I knew.  Looks like it won't be
necessary here because of our strict 1:1 Native:Java object relationship.

+  JNIEnv* env = base::android::AttachCurrentThread();
+  java_object_.Reset(Java_SpellCheckerSessionBridge_create(
+      env, reinterpret_cast<intptr_t>(this)));
+}
+
+void SpellCheckerSessionBridge::RequestTextCheck(int route_id,
+                                                 int identifier,
+                                                 const base::string16& text) {
+  route_id_ = route_id;
+  identifier_ = identifier;
+
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_SpellCheckerSessionBridge_checkSpelling(
+      env, java_object_.obj(),
+      base::android::ConvertUTF16ToJavaString(env, text).obj());
+}
+
+// static
+bool SpellCheckerSessionBridge::RegisterSpellCheckerSessionBridge(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
+void SpellCheckerSessionBridge::GetSpellcheckInfo(JNIEnv* env,
+                                                  jobject jobj,
+                                                  jstring text,
+                                                  jintArray offsetArray,
+                                                  jintArray lengthArray) {
+  std::vector<int> offsets;
+  std::vector<int> lengths;
+  std::vector<SpellCheckResult> local_results;

[please use gerrit instead, 2015/08/11 16:43:47]

Define local_results right before you use it (above the for loop).

[please use gerrit instead, 2015/08/11 16:43:47]

Just "results". It's simpler.

[dylanking, 2015/08/12 01:29:55]

http://nuserve.co.uk/blog/wp-content/uploads/2013/12/JT_Sean_Parker_blog-300x...

Done! :P

+
+  base::android::JavaIntArrayToIntVector(env, offsetArray, &offsets);
+  base::android::JavaIntArrayToIntVector(env, lengthArray, &lengths);
+
+  for (unsigned int j = 0; j < offsets.size(); j++) {
+    local_results.push_back(
+        SpellCheckResult(SpellCheckResult::SPELLING, offsets[j], lengths[j]));
+  }
+
+  content::RenderProcessHost* sender =
+      content::RenderProcessHost::FromID(render_process_id_);
+
+  if (sender) {
+    sender->Send(new SpellCheckMsg_RespondTextCheck(
+        route_id_, identifier_,
+        base::android::ConvertJavaStringToUTF16(env, text), local_results));
+  }
+}