media/audio/win/core_audio_util_win.cc - Issue 1275783003: Add a virtual beamforming audio device on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/core_audio_util_win.cc

Issue 1275783003: Add a virtual beamforming audio device on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix more constructors and disable for now. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_processor_options.cc ('K') | « media/audio/win/audio_manager_win.cc ('k') | media/base/audio_buffer_converter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/win/core_audio_util_win.cc

diff --git a/media/audio/win/core_audio_util_win.cc b/media/audio/win/core_audio_util_win.cc

index ce1793e0c28d157d81500966fcc7c0c3e7c285d7..a6d97afc26c1badb8f74499fd31b0594860e7e34 100644

--- a/media/audio/win/core_audio_util_win.cc

+++ b/media/audio/win/core_audio_util_win.cc

@@ -786,10 +786,10 @@ HRESULT CoreAudioUtil::GetPreferredAudioParameters(const std::string& device_id,

GetDeviceID(communications_device.get()) == GetDeviceID(device.get())) {

// Raise the 'DUCKING' flag for default communication devices.

*params =

- AudioParameters(params->format(), params->channel_layout(),

- params->channels(), params->sample_rate(),

+ AudioParameters(params->format(), params->channels(),

+ params->channel_layout(), params->sample_rate(),

params->bits_per_sample(), params->frames_per_buffer(),

- params->effects() | AudioParameters::DUCKING);

+ "", params->effects() | AudioParameters::DUCKING);

}

return hr;