content/renderer/media/webrtc_local_audio_renderer.cc - Issue 1275783003: Add a virtual beamforming audio device on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_renderer.cc

Issue 1275783003: Add a virtual beamforming audio device on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only add virtual device if we have at least two mics. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | media/audio/cras/audio_manager_cras.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_local_audio_renderer.cc

diff --git a/content/renderer/media/webrtc_local_audio_renderer.cc b/content/renderer/media/webrtc_local_audio_renderer.cc

index 55282c8d62f7fa5c605637a0664fb3dc4d08e694..71488c3124e6be4d526ec3c6ed045538c1d35484 100644

--- a/content/renderer/media/webrtc_local_audio_renderer.cc

+++ b/content/renderer/media/webrtc_local_audio_renderer.cc

@@ -263,12 +263,12 @@ void WebRtcLocalAudioRenderer::ReconfigureSink(

source_params_ = params;

- sink_params_ = media::AudioParameters(source_params_.format(),

- source_params_.channel_layout(), source_params_.sample_rate(),

- source_params_.bits_per_sample(),

+ sink_params_ = media::AudioParameters(

+ source_params_.format(), source_params_.channel_layout(),

+ source_params_.sample_rate(), source_params_.bits_per_sample(),

WebRtcAudioRenderer::GetOptimalBufferSize(source_params_.sample_rate(),

frames_per_buffer_),

- source_params_.effects());

+ std::vector<media::Point>(), source_params_.effects());

{

// Note: The max buffer is fairly large, but will rarely be used.