content/renderer/media/webrtc_audio_capturer.cc - Issue 1275783003: Add a virtual beamforming audio device on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.cc

Issue 1275783003: Add a virtual beamforming audio device on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only add virtual device if we have at least two mics. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/mock_media_constraint_factory.cc ('k') | content/renderer/media/webrtc_local_audio_renderer.cc » ('j') | media/audio/cras/audio_manager_cras.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer.cc

diff --git a/content/renderer/media/webrtc_audio_capturer.cc b/content/renderer/media/webrtc_audio_capturer.cc

index e1f71c3af038d7598fa44324afde62970b3b0073..15a10b6848d39e96ccc4fb868c20f5e156ade589 100644

--- a/content/renderer/media/webrtc_audio_capturer.cc

+++ b/content/renderer/media/webrtc_audio_capturer.cc

@@ -244,7 +244,7 @@ WebRtcAudioCapturer::WebRtcAudioCapturer(

: constraints_(constraints),

audio_processor_(new rtc::RefCountedObject<MediaStreamAudioProcessor>(

constraints,

- device_info.device.input.effects,

+ device_info.device.input,

audio_device)),

running_(false),

render_frame_id_(render_frame_id),

@@ -343,10 +343,8 @@ void WebRtcAudioCapturer::SetCapturerSourceInternal(

// which would normally be used by default.

// bits_per_sample is always 16 for now.

media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,

- channel_layout,

- sample_rate,

- 16,

- buffer_size,

+ channel_layout, sample_rate, 16, buffer_size,

+ std::vector<media::Point>(),

device_info_.device.input.effects);

{