Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: media/audio/cras/audio_manager_cras.h

Issue 1275783003: Add a virtual beamforming audio device on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More constructors. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/cras/audio_manager_cras.h
diff --git a/media/audio/cras/audio_manager_cras.h b/media/audio/cras/audio_manager_cras.h
index 4c8f992ee05a61dc041a49f9a37a6df846986e6d..0a9135c522bb7f158b0c69398fd1e3a76182c096 100644
--- a/media/audio/cras/audio_manager_cras.h
+++ b/media/audio/cras/audio_manager_cras.h
@@ -61,6 +61,12 @@ class MEDIA_EXPORT AudioManagerCras : public AudioManagerBase {
bool has_keyboard_mic_;
+ // Holds the name and ID of a virtual beamforming device if the machine
+ // indicates it has a mic array by providing a mic positions field.
+ const AudioDeviceName beamforming_device_name_;
Henrik Grunell 2015/08/27 08:38:18 Why is it restricted to only the default device?
ajm 2015/08/28 07:36:13 AudioManagerCras only exposes a single device call
aluebs-chromium 2015/08/28 19:14:30 Do these really need to be part of the state of th
ajm 2015/08/28 23:38:31 They're immutable, so we're not expanding the "sta
aluebs-chromium 2015/08/29 00:00:26 Agreed.
+ // Stores the mic positions field from the device.
Henrik Grunell 2015/08/27 08:38:18 Nit: Empty line before comment.
+ const std::string mic_positions_;
+
DISALLOW_COPY_AND_ASSIGN(AudioManagerCras);
};

Powered by Google App Engine
This is Rietveld 408576698