Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: platform_tools/android/gyp/dependencies.gypi

Issue 1275773004: Switching Skia to chromium's libjpeg-turbo (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update DEPS with libjpeg-turbo fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/libjpeg-turbo.gyp ('k') | src/codec/SkJpegCodec.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/gyp/dependencies.gypi
diff --git a/platform_tools/android/gyp/dependencies.gypi b/platform_tools/android/gyp/dependencies.gypi
index fb9e80bb4a0860b0e603b81c79fe9d8a952e4c38..f6298c1558da8ca283db47384a902829b24f764a 100644
--- a/platform_tools/android/gyp/dependencies.gypi
+++ b/platform_tools/android/gyp/dependencies.gypi
@@ -183,18 +183,22 @@
'../third_party/externals/jpeg/jutils.c',
],
'conditions': [
- [ 'arm_neon == 1 and skia_clang_build == 0',
- {
- 'sources' : [
- '../third_party/externals/jpeg/armv6_idct.S',
- '../third_party/externals/jpeg/jsimd_arm_neon.S',
- '../third_party/externals/jpeg/jsimd_neon.c',
- ],
- 'defines' : [
- 'NV_ARM_NEON',
- ],
- },
- ],
+ # FIXME (msarett):
+ # Turn off Arm NEON optimizations to avoid namespace conflicts when
+ # compiling libjpeg and libjpeg-turbo. This is a temporary step in the
+ # plan to replace libjpeg with libjpeg-turbo.
+ #[ 'arm_neon == 1 and skia_clang_build == 0',
+ # {
+ # 'sources' : [
+ # '../third_party/externals/jpeg/armv6_idct.S',
+ # '../third_party/externals/jpeg/jsimd_arm_neon.S',
+ # '../third_party/externals/jpeg/jsimd_neon.c',
+ # ],
+ # 'defines' : [
+ # 'NV_ARM_NEON',
+ # ],
+ # },
+ #],
[ '"mips" in skia_arch_type and mips_dsp == 2',
{
'sources' : [
« no previous file with comments | « gyp/libjpeg-turbo.gyp ('k') | src/codec/SkJpegCodec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698