content/common/platform_notification_messages.h - Issue 1275743003: Deliver action clicks to page notifications (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 1275743003: Deliver action clicks to page notifications (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_test

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_object_proxy.cc ('K') | « content/child/notifications/notification_manager.cc ('k') | content/public/browser/desktop_notification_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index 90445284f8a588ce28b8dc8b39b5a2164495a8df..f186b34895ee14e38e715878723dbb142489a096 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -63,9 +63,12 @@ IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidShow,

IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidClose,

int /* notification_id */)

-// Informs the renderer that the notification has been clicked on.

-IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidClick,

- int /* notification_id */)

+// Informs the renderer that the notification or one of its actions have been

+// clicked on. |action_index| is the index of the action, or -1 if the main body

+// of the notification was clicked.

+IPC_MESSAGE_CONTROL2(PlatformNotificationMsg_DidClick,

+ int /* notification_id */,

+ int /* action_index */)

// Reply to PlatformNotificationHostMsg_ShowPersistent indicating that a

// persistent notification has been shown on the platform (if |success| is