content/child/notifications/notification_manager.cc - Issue 1275743003: Deliver action clicks to page notifications (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_manager.cc

Issue 1275743003: Deliver action clicks to page notifications (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_test

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_object_proxy.cc ('K') | « content/browser/notifications/page_notification_delegate.cc ('k') | content/common/platform_notification_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_manager.cc

diff --git a/content/child/notifications/notification_manager.cc b/content/child/notifications/notification_manager.cc

index 95195455295633da3dab73e4b12351c0e8c3303e..2731fc1206af59a5e6fa4bc0e7557555256fa2e9 100644

--- a/content/child/notifications/notification_manager.cc

+++ b/content/child/notifications/notification_manager.cc

@@ -274,12 +274,12 @@ void NotificationManager::OnDidClose(int notification_id) {

active_page_notifications_.erase(iter);

}

-void NotificationManager::OnDidClick(int notification_id) {

+void NotificationManager::OnDidClick(int notification_id, int action_index) {

const auto& iter = active_page_notifications_.find(notification_id);

if (iter == active_page_notifications_.end())

return;

- iter->second->dispatchClickEvent();

+ iter->second->dispatchClickEvent(action_index);

}

void NotificationManager::OnDidGetNotifications(