chrome/browser/notifications/notification_object_proxy.cc - Issue 1275743003: Deliver action clicks to page notifications (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_object_proxy.cc

Issue 1275743003: Deliver action clicks to page notifications (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_test

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_object_proxy.h ('k') | chrome/browser/notifications/platform_notification_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_object_proxy.cc

diff --git a/chrome/browser/notifications/notification_object_proxy.cc b/chrome/browser/notifications/notification_object_proxy.cc

index e98a82cde6d25e7cef1d72fcd2321c4dc423e02e..b46b1acd92855d9d641c12e07e7b7cb92349162e 100644

--- a/chrome/browser/notifications/notification_object_proxy.cc

+++ b/chrome/browser/notifications/notification_object_proxy.cc

@@ -30,7 +30,11 @@ void NotificationObjectProxy::Close(bool by_user) {

}

void NotificationObjectProxy::Click() {

- delegate_->NotificationClick();

+ delegate_->NotificationClick(-1);

Peter Beverloo 2015/08/07 07:27:28 +comment (but preferably a constant, as you sugges

+void NotificationObjectProxy::ButtonClick(int button_index) {

+ delegate_->NotificationClick(button_index);

}

std::string NotificationObjectProxy::id() const {