Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 12757003: Revert 188637 "Added text line limits to collapsed and expanded ..." (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
dharcourt
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 188637 "Added text line limits to collapsed and expanded ..." It appears that r188637 is causing flakiness of ash_unittests on Win8 Aura: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/3400 > Added text line limits to collapsed and expanded notifications. > > This is done through a new BoundedLabel views::Label subclass that > supports a max_lines value. This class comes with unit tests covering > its basic functionality. > > Also, the Notifications Galore! test app was updated to include test > notifications with long titles, long messages, and long items which can > be used for manual tests of the line limits. > > As with the rest of the collapse/expand functionality currently > committed, this only applies to the notification center. Notification > toasts are currently still always expanded and text line limits have not > been tested for them. > > There are some known issues with incorrect notification card sizes in > the notification center after some sequence of create/destroy > operations, and these will be addressed in a separate change list. > > BUG=161098, 168939, 168940 > R=dewittj@chromium.org > TBR=mukai@chromium.org > > > Review URL: https://chromiumcodereview.appspot.com/12742005 TBR=dharcourt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -585 lines) Patch
M chrome/test/data/extensions/api_test/notifications/galore/app/data/27.0.0.0.json View 4 chunks +10 lines, -19 lines 0 comments Download
M chrome/test/data/extensions/api_test/notifications/galore/app/data/27.0.1432.2.json View 4 chunks +10 lines, -19 lines 0 comments Download
M chrome/test/data/extensions/api_test/notifications/galore/app/data/27.0.1433.1.json View 4 chunks +10 lines, -19 lines 0 comments Download
M chrome/test/data/extensions/api_test/notifications/galore/app/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_center.gyp View 2 chunks +5 lines, -19 lines 0 comments Download
D ui/message_center/run_all_unittests.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/message_center/views/bounded_label.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ui/message_center/views/bounded_label.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D ui/message_center/views/bounded_label_unittest.cc View 1 chunk +0 lines, -224 lines 0 comments Download
M ui/message_center/views/notification_view.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 8 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alexeypa (please no reviews)
7 years, 9 months ago (2013-03-18 02:12:01 UTC) #1
alexeypa (please no reviews)
Committed patchset #1 manually as r188663.
7 years, 9 months ago (2013-03-18 02:12:11 UTC) #2
alexeypa (please no reviews)
7 years, 9 months ago (2013-03-18 02:14:04 UTC) #3
Message was sent while issue was closed.
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/3400:

WebNotificationTrayTest.ManyMessageCenterNotifications: 
[3956:1376:0317/061532:8584173:ERROR:cursor_loader_win.cc(85)] NOT IMPLEMENTED
[3956:1376:0317/061552:8604375:INFO:test_metro_viewer_process_host.cc(110)]
ash::test::TestMetroViewerProcessHost::OnSetTargetSurface, target_surface =
17826430
c:\b\build\slave\win_aura_builder\build\src\ash\test\ash_test_base.cc(143):
error: Value of: metro_viewer_host_->closed_unexpectedly()
Actual: true
Expected: false

WebNotificationTrayTest.ManyPopupNotifications: 
Did not complete.

Powered by Google App Engine
This is Rietveld 408576698