Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Side by Side Diff: base/debug/task_annotator.cc

Issue 1275693002: Change PostTask to use Flow v2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove braces. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/debug/task_annotator.h" 5 #include "base/debug/task_annotator.h"
6 6
7 #include "base/debug/alias.h" 7 #include "base/debug/alias.h"
8 #include "base/pending_task.h" 8 #include "base/pending_task.h"
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "base/tracked_objects.h" 10 #include "base/tracked_objects.h"
11 11
12 namespace base { 12 namespace base {
13 namespace debug { 13 namespace debug {
14 14
15 TaskAnnotator::TaskAnnotator() { 15 TaskAnnotator::TaskAnnotator() {
16 } 16 }
17 17
18 TaskAnnotator::~TaskAnnotator() { 18 TaskAnnotator::~TaskAnnotator() {
19 } 19 }
20 20
21 void TaskAnnotator::DidQueueTask(const char* queue_function, 21 void TaskAnnotator::DidQueueTask(const char* queue_function,
22 const PendingTask& pending_task) { 22 const PendingTask& pending_task) {
23 TRACE_EVENT_FLOW_BEGIN0(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"), 23 TRACE_EVENT_WITH_FLOW0(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"),
24 queue_function, 24 queue_function,
25 TRACE_ID_MANGLE(GetTaskTraceID(pending_task))); 25 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)),
26 TRACE_EVENT_FLAG_FLOW_OUT);
26 } 27 }
27 28
28 void TaskAnnotator::RunTask(const char* queue_function, 29 void TaskAnnotator::RunTask(const char* queue_function,
29 const PendingTask& pending_task) { 30 const PendingTask& pending_task) {
30 tracked_objects::TaskStopwatch stopwatch; 31 tracked_objects::TaskStopwatch stopwatch;
31 stopwatch.Start(); 32 stopwatch.Start();
32 tracked_objects::Duration queue_duration = 33 tracked_objects::Duration queue_duration =
33 stopwatch.StartTime() - pending_task.EffectiveTimePosted(); 34 stopwatch.StartTime() - pending_task.EffectiveTimePosted();
34 35
35 TRACE_EVENT_FLOW_END1(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"), 36 TRACE_EVENT_WITH_FLOW1(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"),
36 queue_function, 37 queue_function,
37 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)), 38 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)),
38 "queue_duration", 39 TRACE_EVENT_FLAG_FLOW_IN,
39 queue_duration.InMilliseconds()); 40 "queue_duration",
41 queue_duration.InMilliseconds());
40 42
41 // Before running the task, store the program counter where it was posted 43 // Before running the task, store the program counter where it was posted
42 // and deliberately alias it to ensure it is on the stack if the task 44 // and deliberately alias it to ensure it is on the stack if the task
43 // crashes. Be careful not to assume that the variable itself will have the 45 // crashes. Be careful not to assume that the variable itself will have the
44 // expected value when displayed by the optimizer in an optimized build. 46 // expected value when displayed by the optimizer in an optimized build.
45 // Look at a memory dump of the stack. 47 // Look at a memory dump of the stack.
46 const void* program_counter = pending_task.posted_from.program_counter(); 48 const void* program_counter = pending_task.posted_from.program_counter();
47 debug::Alias(&program_counter); 49 debug::Alias(&program_counter);
48 50
49 pending_task.task.Run(); 51 pending_task.task.Run();
50 52
51 stopwatch.Stop(); 53 stopwatch.Stop();
52 tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking( 54 tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking(
53 pending_task, stopwatch); 55 pending_task, stopwatch);
54 } 56 }
55 57
56 uint64 TaskAnnotator::GetTaskTraceID(const PendingTask& task) const { 58 uint64 TaskAnnotator::GetTaskTraceID(const PendingTask& task) const {
57 return (static_cast<uint64>(task.sequence_num) << 32) | 59 return (static_cast<uint64>(task.sequence_num) << 32) |
58 ((static_cast<uint64>(reinterpret_cast<intptr_t>(this)) << 32) >> 32); 60 ((static_cast<uint64>(reinterpret_cast<intptr_t>(this)) << 32) >> 32);
59 } 61 }
60 62
61 } // namespace debug 63 } // namespace debug
62 } // namespace base 64 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698