Chromium Code Reviews

Issue 1275683002: Rename "extras exports" to "extras binding" (Closed)

Created:
5 years, 4 months ago by domenic
Modified:
5 years, 4 months ago
Reviewers:
jochen (gone - plz use gerrit), Yang
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename "extras exports" to "extras binding" R=yangguo@chromium.org, jochen@chromium.org BUG=507133 LOG=Y Committed: https://crrev.com/2dff84e66fd3c26a08aa214ee9a8d8d7cccb396c Cr-Commit-Position: refs/heads/master@{#30053}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+23 lines, -21 lines)
M include/v8.h View 1 chunk +5 lines, -3 lines 0 comments
M src/api.cc View 1 chunk +3 lines, -3 lines 0 comments
M src/bootstrapper.cc View 2 chunks +6 lines, -6 lines 0 comments
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments
M test/cctest/test-api.cc View 1 chunk +4 lines, -4 lines 0 comments
M test/cctest/test-extra.js View 1 chunk +4 lines, -4 lines 0 comments

Messages

Total messages: 7 (1 generated)
domenic
Technically a breaking change... in an API nobody is using, hopefully?
5 years, 4 months ago (2015-08-05 19:05:23 UTC) #1
Yang
On 2015/08/05 19:05:23, domenic wrote: > Technically a breaking change... in an API nobody is ...
5 years, 4 months ago (2015-08-06 05:51:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-06 07:39:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275683002/1
5 years, 4 months ago (2015-08-06 22:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 23:52:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:53:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2dff84e66fd3c26a08aa214ee9a8d8d7cccb396c
Cr-Commit-Position: refs/heads/master@{#30053}

Powered by Google App Engine