Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1275633002: win: Provide strcasecmp() in <strings.h> in compat (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Provide strcasecmp() in <strings.h> in compat. base::strcasecmp() has been deprecated since upstream 8a800901b78a2. BUG=chromium:472900 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/03663076154abef3db3377a381f73d95ffb6677b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -3 lines) Patch
M compat/compat.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A compat/win/strings.h View 1 chunk +28 lines, -0 lines 0 comments Download
A compat/win/strings.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M tools/crashpad_database_util.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-05 18:07:19 UTC) #2
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-05 20:21:17 UTC) #3
Mark Mentovai
5 years, 4 months ago (2015-08-05 20:34:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03663076154abef3db3377a381f73d95ffb6677b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698