chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm - Issue 1275623004: [Extensions] Expand testing overrides for extension warning bubbles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

Issue 1275623004: [Extensions] Expand testing overrides for extension warning bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h ('k') | chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

index d757efb00b59689d43f20648b9e5452e55a942cc..fab0ae3cb478c7acb3f0103d07b66f632a694d9a 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

@@ -50,8 +50,9 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, FullscreenHasLocationBar) {

bubble.Hide();

}

-IN_PROC_BROWSER_TEST_F(PermissionBubbleAppBrowserTest, AppHasNoLocationBar) {

- PermissionBubbleCocoa bubble(app_browser());

+IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, AppHasNoLocationBar) {

+ Browser* app_browser = OpenExtensionAppWindow();

+ PermissionBubbleCocoa bubble(app_browser);

bubble.SetDelegate(test_delegate());

bubble.Show(requests(), accept_states());

EXPECT_FALSE(bubble.HasLocationBar());