Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/ui/extensions/extension_message_bubble_factory.h

Issue 1275623004: [Extensions] Expand testing overrides for extension warning bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_ 5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_
6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_ 6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 10
11 class Browser; 11 class Browser;
12 12
13 namespace extensions { 13 namespace extensions {
14 class ExtensionMessageBubbleController; 14 class ExtensionMessageBubbleController;
15 } // namespace extensions 15 } // namespace extensions
16 16
17 // Create and show ExtensionMessageBubbles for either extensions that look 17 // Create and show ExtensionMessageBubbles for either extensions that look
18 // suspicious and have therefore been disabled, or for extensions that are 18 // suspicious and have therefore been disabled, or for extensions that are
19 // running in developer mode that we want to warn the user about. 19 // running in developer mode that we want to warn the user about.
20 class ExtensionMessageBubbleFactory { 20 class ExtensionMessageBubbleFactory {
21 public: 21 public:
22 // An enum to allow us to override the default behavior for testing.
23 enum OverrideForTesting {
24 NO_OVERRIDE,
25 OVERRIDE_ENABLED,
26 OVERRIDE_DISABLED,
27 };
28
22 explicit ExtensionMessageBubbleFactory(Browser* browser); 29 explicit ExtensionMessageBubbleFactory(Browser* browser);
23 ~ExtensionMessageBubbleFactory(); 30 ~ExtensionMessageBubbleFactory();
24 31
25 // Returns the controller for the bubble that should be shown, if any. 32 // Returns the controller for the bubble that should be shown, if any.
26 scoped_ptr<extensions::ExtensionMessageBubbleController> GetController(); 33 scoped_ptr<extensions::ExtensionMessageBubbleController> GetController();
27 34
28 // Enables the bubbles across all platforms for testing. 35 // Overrides the default behavior for testing.
29 static void set_enabled_for_tests(bool enabled); 36 static void set_override_for_tests(OverrideForTesting override);
30 37
31 private: 38 private:
32 Browser* browser_; 39 Browser* browser_;
33 40
34 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleFactory); 41 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleFactory);
35 }; 42 };
36 43
37 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_ 44 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698