Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

Issue 1275623004: [Extensions] Expand testing overrides for extension warning bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h" 5 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h"
6 6
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "chrome/browser/extensions/extension_action_test_util.h" 8 #include "chrome/browser/extensions/extension_action_test_util.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/ui/extensions/extension_message_bubble_factory.h" 10 #include "chrome/browser/ui/extensions/extension_message_bubble_factory.h"
11 #include "extensions/common/feature_switch.h" 11 #include "extensions/common/feature_switch.h"
12 12
13 ExtensionMessageBubbleBrowserTest::ExtensionMessageBubbleBrowserTest() { 13 ExtensionMessageBubbleBrowserTest::ExtensionMessageBubbleBrowserTest() {
14 } 14 }
15 15
16 ExtensionMessageBubbleBrowserTest::~ExtensionMessageBubbleBrowserTest() { 16 ExtensionMessageBubbleBrowserTest::~ExtensionMessageBubbleBrowserTest() {
17 } 17 }
18 18
19 void ExtensionMessageBubbleBrowserTest::SetUpCommandLine( 19 void ExtensionMessageBubbleBrowserTest::SetUpCommandLine(
20 base::CommandLine* command_line) { 20 base::CommandLine* command_line) {
21 BrowserActionsBarBrowserTest::SetUpCommandLine(command_line); 21 BrowserActionsBarBrowserTest::SetUpCommandLine(command_line);
22 // The dev mode warning bubble is an easy one to trigger, so we use that for 22 // The dev mode warning bubble is an easy one to trigger, so we use that for
23 // our testing purposes. 23 // our testing purposes.
24 dev_mode_bubble_override_.reset( 24 dev_mode_bubble_override_.reset(
25 new extensions::FeatureSwitch::ScopedOverride( 25 new extensions::FeatureSwitch::ScopedOverride(
26 extensions::FeatureSwitch::force_dev_mode_highlighting(), 26 extensions::FeatureSwitch::force_dev_mode_highlighting(),
27 true)); 27 true));
28 ExtensionMessageBubbleFactory::set_enabled_for_tests(true); 28 ExtensionMessageBubbleFactory::set_override_for_tests(
29 ExtensionMessageBubbleFactory::OVERRIDE_ENABLED);
29 } 30 }
30 31
31 void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToExtensionAction() { 32 void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToExtensionAction() {
32 scoped_refptr<const extensions::Extension> action_extension = 33 scoped_refptr<const extensions::Extension> action_extension =
33 extensions::extension_action_test_util::CreateActionExtension( 34 extensions::extension_action_test_util::CreateActionExtension(
34 "action_extension", 35 "action_extension",
35 extensions::extension_action_test_util::BROWSER_ACTION, 36 extensions::extension_action_test_util::BROWSER_ACTION,
36 extensions::Manifest::UNPACKED); 37 extensions::Manifest::UNPACKED);
37 extension_service()->AddExtension(action_extension.get()); 38 extension_service()->AddExtension(action_extension.get());
38 39
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 87
87 void ExtensionMessageBubbleBrowserTest::PreBubbleShowsOnStartup() { 88 void ExtensionMessageBubbleBrowserTest::PreBubbleShowsOnStartup() {
88 LoadExtension(test_data_dir_.AppendASCII("good_unpacked")); 89 LoadExtension(test_data_dir_.AppendASCII("good_unpacked"));
89 } 90 }
90 91
91 void ExtensionMessageBubbleBrowserTest::TestBubbleShowsOnStartup() { 92 void ExtensionMessageBubbleBrowserTest::TestBubbleShowsOnStartup() {
92 base::RunLoop().RunUntilIdle(); 93 base::RunLoop().RunUntilIdle();
93 CheckBubble(browser(), ANCHOR_BROWSER_ACTION); 94 CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
94 CloseBubble(browser()); 95 CloseBubble(browser());
95 } 96 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698