Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1275603002: Expose coord transforms from GrPipeline (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@lccleanup4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Expose coord transforms from GrPipeline BUG=skia: Committed: https://skia.googlesource.com/skia/+/2fe7923f7e74f901a17afba7609d71a1220bdc60

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 2 chunks +17 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 3 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 3 chunks +13 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
joshualitt
ptal. Eventually we can go a step farther and always have GrBatch do the coord ...
5 years, 4 months ago (2015-08-05 16:34:44 UTC) #2
bsalomon
https://codereview.chromium.org/1275603002/diff/1/include/gpu/GrFragmentProcessor.h File include/gpu/GrFragmentProcessor.h (right): https://codereview.chromium.org/1275603002/diff/1/include/gpu/GrFragmentProcessor.h#newcode87 include/gpu/GrFragmentProcessor.h:87: generate the same shader code. To test for identical ...
5 years, 4 months ago (2015-08-05 17:22:12 UTC) #3
joshualitt
https://codereview.chromium.org/1275603002/diff/1/include/gpu/GrFragmentProcessor.h File include/gpu/GrFragmentProcessor.h (right): https://codereview.chromium.org/1275603002/diff/1/include/gpu/GrFragmentProcessor.h#newcode87 include/gpu/GrFragmentProcessor.h:87: generate the same shader code. To test for identical ...
5 years, 4 months ago (2015-08-05 17:46:21 UTC) #5
bsalomon
lgtm
5 years, 4 months ago (2015-08-05 18:52:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275603002/20001
5 years, 4 months ago (2015-08-05 18:54:07 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 19:02:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2fe7923f7e74f901a17afba7609d71a1220bdc60

Powered by Google App Engine
This is Rietveld 408576698