Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1275573002: Fix idle step marking after 9d7ebc. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix idle step marking after 9d7ebc. Idle notification should force marking to make progress. BUG= Committed: https://crrev.com/da97af0d016aa69b78551de6b953f0624e8d6792 Cr-Commit-Position: refs/heads/master@{#30041}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
ptal
5 years, 4 months ago (2015-08-05 16:07:37 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-05 16:08:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275573002/1
5 years, 4 months ago (2015-08-05 16:12:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/6385)
5 years, 4 months ago (2015-08-05 16:14:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275573002/20001
5 years, 4 months ago (2015-08-06 09:49:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-06 10:14:56 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 10:15:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da97af0d016aa69b78551de6b953f0624e8d6792
Cr-Commit-Position: refs/heads/master@{#30041}

Powered by Google App Engine
This is Rietveld 408576698