Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1275543004: Resolve some input focus issues for the debugger. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index ae0ab6f24b11cfa5ff6361146561e87ac4b37a39..b4709c9c44cda311e7241563e2886d67f2f60d7a 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -1484,7 +1484,8 @@ class DebuggerPageElement extends ObservatoryElement {
// Random clicks should focus on the text box. If the user selects
// a range, don't interfere.
var selection = window.getSelection();
- if (selection == null || selection.type == 'Caret') {
+ if (selection == null ||
+ (selection.type != 'Range' && selection.type != 'text')) {
debugger.input.focus();
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698