Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: tools/grokdump.py

Issue 12755031: Disable grokdumps module decoding temporarily. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grokdump.py
diff --git a/tools/grokdump.py b/tools/grokdump.py
index 2fbe3b44fce045755c3b6d9c538dfe451be098b8..7daad21eeb08dcfdfab7a9df1344648da61f1192 100755
--- a/tools/grokdump.py
+++ b/tools/grokdump.py
@@ -2085,13 +2085,14 @@ def AnalyzeMinidump(options, minidump_name):
else:
print " eflags: %s" % bin(reader.exception_context.eflags)[2:]
- print
- print " modules:"
- for module in reader.module_list.modules:
- name = GetModuleName(reader, module)
- if name in KNOWN_MODULES:
- print " %s at %08X" % (name, module.base_of_image)
- reader.TryLoadSymbolsFor(name, module)
+ # TODO(mstarzinger): Disabled because broken, needs investigation.
+ #print
+ #print " modules:"
+ #for module in reader.module_list.modules:
+ # name = GetModuleName(reader, module)
+ # if name in KNOWN_MODULES:
+ # print " %s at %08X" % (name, module.base_of_image)
+ # reader.TryLoadSymbolsFor(name, module)
print
stack_top = reader.ExceptionSP()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698