add cache list command to pub

utils/pub/hosted_source.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library hosted_source;
 
 import 'dart:async';
 import 'dart:io' as io;
 import 'dart:json' as json;
 import 'dart:uri';
@@ skipping 100 matching lines @@
   ///
   /// There are two valid formats. A plain string refers to a package with the
   /// given name from the default host, while a map with keys "name" and "url"
   /// refers to a package with the given name from the host at the given URL.
   dynamic parseDescription(String containingPath, description,
                            {bool fromLockFile: false}) {
     _parseDescription(description);
     return description;
   }
 
+  /// Returns a list of packages in the default cache

[Bob Nystrom, 2013/03/12 22:12:03]

Remove this comment.

[keertip, 2013/03/13 15:55:00]

Done.

+  Future<List<Package>> getCachedPackages() {
+    var url = _defaultUrl.replaceAll(new RegExp(r"^https?://"), "");

[Bob Nystrom, 2013/03/12 22:12:03]

Can you pull this out into a separate function and call it from here and line
96?

[keertip, 2013/03/13 15:55:00]

Done.

+    return listDir(path.join(systemCacheRoot,url)).then((entries){

[Bob Nystrom, 2013/03/12 22:12:03]

Space after "," and between ")" and "{".

[keertip, 2013/03/13 15:55:00]

Done.

+      var list = new List();
+      for (var entry in entries) {
+        var name = path.basename(entry).replaceAll(new RegExp(r"-(.*)"),"");

[Bob Nystrom, 2013/03/12 22:12:03]

How about:

path.basename(entry).split('-')[0];

[nweiz, 2013/03/12 22:58:48]

Both of these are dangerous if a package has a hyphen in its name. If you pass
null here, it should detect the name from the pubspec, which is safer.

+        var p = new Package.load(name, entry, systemCache.sources);
+        list.add(p);
+      }
+      return list;

[Bob Nystrom, 2013/03/12 22:12:03]

return entries.map((entry) {
  var name = ...
  return new Package.load...
});

[keertip, 2013/03/13 15:55:00]

Done.

+    }).catchError((ex) {
+      throw 'Could not list packages in pub cache ${ex}';

[Bob Nystrom, 2013/03/12 22:12:03]

Don't bother catching this.

[keertip, 2013/03/13 15:55:00]

Done.

+    });
+  }
+  
   /// When an error occurs trying to read something about [package] from [url],
   /// this tries to translate into a more user friendly error message. Always
   /// throws an error, either the original one or a better one.
   void _throwFriendlyError(AsyncError asyncError, package, url) {
     if (asyncError.error is PubHttpException &&
         asyncError.error.response.statusCode == 404) {
       throw 'Could not find package "$package" at $url.';
     }
 
     if (asyncError.error is TimeoutException) {
@@ skipping 56 matching lines @@
   }
 
   var name = description["name"];
   if (name is! String) {
     throw new FormatException("The 'name' key must have a string value.");
   }
 
   var url = description.containsKey("url") ? description["url"] : _defaultUrl;
   return new Pair<String, String>(name, url);
 }